Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23707 )
Change subject: KUDU-1457 [8/n] Parameterize tests with ip config ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23707/4/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/23707/4/src/kudu/util/test_util.cc@762 PS4, Line 762: void PrintTo(IPMode param, std::ostream* os) { : *os << GetIPConfigMode(param); : } > With operator overload approach, I guess I didn't see right file for defini Right -- as for the place to put the definition, it's no different from any other function, e.g. PrintTo(). So, then there isn't a problem with that anymore, I guess. If so, do you think it make sense to to transition to the operator-based approach or you'd rather keep PrintTo()? -- To view, visit http://gerrit.cloudera.org:8080/23707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic72efea2045b12300ccf0e80873c405828c15a30 Gerrit-Change-Number: 23707 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 04 Feb 2026 22:16:24 +0000 Gerrit-HasComments: Yes
