Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23711 )
Change subject: KUDU-1457 [7/n] Use correct URL host for ip mode ...................................................................... KUDU-1457 [7/n] Use correct URL host for ip mode This patch uses correct URL host for a given IP config mode. If webserver is running on wildcard address, tests using URL as input to FetchURL need to make use of a corresponding loopback address. For example, for a webserver running on '0.0.0.0', URL host is '127.0.0.1' and similarly, for a webserver running on '[::]', URL host is '[::1]'. * Based on IP config mode, choose correct service principal name. * Ensure test certificate contains subject name that matches with target hostname for non-IPv4 cases (i.e. when IP address is ::1). For this, new certificate and corresponding key is added with same configuration with additional subject name to accomodate '::1'. * Add a few more tests to IP config coverage. Change-Id: I152b0755f286edce1738683b5d2cdf5804f4ff2a Reviewed-on: http://gerrit.cloudera.org:8080/23711 Reviewed-by: Marton Greber <[email protected]> Tested-by: Marton Greber <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/security/test/test_certs.cc M src/kudu/server/webserver-test.cc 2 files changed, 121 insertions(+), 103 deletions(-) Approvals: Marton Greber: Looks good to me, approved; Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I152b0755f286edce1738683b5d2cdf5804f4ff2a Gerrit-Change-Number: 23711 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
