Zoltan Chovan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23904 )

Change subject: KUDU-3700 Add swagger verification script docs
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23904/2/build-support/verify_swagger_spec.py
File build-support/verify_swagger_spec.py:

http://gerrit.cloudera.org:8080/#/c/23904/2/build-support/verify_swagger_spec.py@183
PS2, Line 183: if not source_methods:
what does this actually check? what is the type of the source_methods variable?


http://gerrit.cloudera.org:8080/#/c/23904/2/build-support/verify_swagger_spec.py@211
PS2, Line 211: parse_args
would it be possible to add a "--help" option to print these flags and the 
default values, I haven't found them documented in the commit msg either



--
To view, visit http://gerrit.cloudera.org:8080/23904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ca60becef11eb2170544f87fafc5d9aa4110a31
Gerrit-Change-Number: 23904
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Wed, 18 Feb 2026 13:06:06 +0000
Gerrit-HasComments: Yes

Reply via email to