Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23904 )
Change subject: KUDU-3700 Add swagger verification script docs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23904/1/build-support/verify_swagger_spec.py File build-support/verify_swagger_spec.py: http://gerrit.cloudera.org:8080/#/c/23904/1/build-support/verify_swagger_spec.py@47 PS1, Line 47: # Matches RegisterPathHandler/RegisterPrerenderedPathHandler argument lists. : REGISTER_HANDLER_RE = re.compile( : r"Register(?:Prerendered)?PathHandler\(\s*(?P<args>.*?)\);\s*", : re.DOTALL, : ) : # Extracts "/api/..." path literals from handler registrations. : PATH_RE = re.compile(r'"(?P<path>/api/[^"]+)"') : # Finds handler method names used in lambdas (e.g., this->HandleFoo). : HANDLER_RE = re.compile(r"this->(?P<handler>\w+)\s*\(") : # Detects explicit method checks (req.request_method == "GET"). : METHOD_EQ_RE = re.compile(r'req\.request_method\s*==\s*"(?P<method>[A-Z]+)"') : # > nit: just for readabilitys sake can you please add comments above the regex Done http://gerrit.cloudera.org:8080/#/c/23904/1/build-support/verify_swagger_spec.py@178 PS1, Line 178: swagger_methods = set(swagger_ops[path].keys()) > The method inference is best?effort and only scans for direct req.request_m Done -- To view, visit http://gerrit.cloudera.org:8080/23904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ca60becef11eb2170544f87fafc5d9aa4110a31 Gerrit-Change-Number: 23904 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 12 Feb 2026 12:01:45 +0000 Gerrit-HasComments: Yes
