Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23348 )
Change subject: KUDU-3734 include undo size while picking rowsets ...................................................................... Patch Set 9: (1 comment) It seems I missed pointing to one obvious point in earlier review rounds, but it's better late than never. http://gerrit.cloudera.org:8080/#/c/23348/9/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: http://gerrit.cloudera.org:8080/#/c/23348/9/src/kudu/tablet/rowset_info.cc@475 PS9, Line 475: if (FLAGS_rowset_merge_compaction_weight_includes_undo_deltas) { : extra_->base_and_deltas_size_bytes = rs->OnDiskBaseDataSizeWithDeltas(); : } else { : extra_->base_and_deltas_size_bytes = rs->OnDiskBaseDataSizeWithRedos(); : } Why to have this logic around FLAGS_rowset_merge_compaction_weight_includes_undo_deltas spread everywhere? Why not to encapsulate the details into the implementation of OnDiskBaseDataSizeWithDeltas() method? -- To view, visit http://gerrit.cloudera.org:8080/23348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I351c0ba96a02e6ded5153adf9d981083a8c40592 Gerrit-Change-Number: 23348 Gerrit-PatchSet: 9 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 24 Feb 2026 20:17:49 +0000 Gerrit-HasComments: Yes
