Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23348 )
Change subject: KUDU-3734 include undo size while picking rowsets ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/23348/9/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: http://gerrit.cloudera.org:8080/#/c/23348/9/src/kudu/tablet/rowset_info.cc@475 PS9, Line 475: if (FLAGS_rowset_merge_compaction_weight_includes_undo_deltas) { : extra_->base_and_deltas_size_bytes = rs->OnDiskBaseDataSizeWithDeltas(); : } else { : extra_->base_and_deltas_size_bytes = rs->OnDiskBaseDataSizeWithRedos(); : } > The idea was to encapsulate the logic into the RowSet::OnDiskBaseDataSizeWi Ah! yes, there is the third place in tablet.cc as well. renaming 'rowset_merge_compaction_weight_includes_undo_deltas' to 'rowset_deltas_size_include_undo' kind of flips my argument in favor of encapsulating the logic of including the size of undo deltas into the OnDiskBaseDataSizeWithDeltas(). This way sounds good to me as the name of the flag name kept aligned with the purpose and also at the right place. -- To view, visit http://gerrit.cloudera.org:8080/23348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I351c0ba96a02e6ded5153adf9d981083a8c40592 Gerrit-Change-Number: 23348 Gerrit-PatchSet: 9 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:14:47 +0000 Gerrit-HasComments: Yes
