Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24040 )
Change subject: [infra] Update build-and-test.sh for Java 17 ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/24040/9/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/24040/9/build-support/jenkins/build-and-test.sh@349 PS9, Line 349: JAVA_8_OVERRIDE > nit: why not JAVA8_OVERRIDE? There are JAVA8_HOME and JAVA17_HOME variable Done http://gerrit.cloudera.org:8080/#/c/24040/9/build-support/jenkins/build-and-test.sh@355 PS9, Line 355: JAVA_8_OVERRIDE > As for special label/tags in a text, usually it makes sense to require a pa I changed the regex so that it matches to a line where nothing else is present just the tag, i.e. ^JAVA8_OVERRIDE$ that way the position of the tag in the commit msg doesn't matter and can be referenced in sentences. http://gerrit.cloudera.org:8080/#/c/24040/9/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java File java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java: http://gerrit.cloudera.org:8080/#/c/24040/9/java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java@150 PS9, Line 150: javaVersion.equals("17") > readability nit: make this a top-level condition and move everything relate Done -- To view, visit http://gerrit.cloudera.org:8080/24040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1d6d65fbd58a8c96d1dca958fc66207893bb99e Gerrit-Change-Number: 24040 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 12:52:10 +0000 Gerrit-HasComments: Yes
