Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24040 )
Change subject: [infra] Update build-and-test.sh for Java 17 ...................................................................... Patch Set 12: (1 comment) Overall looks good to me as of PS12, just one concern about the way to invoke grep when using regex for the matching patter. http://gerrit.cloudera.org:8080/#/c/24040/12/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/24040/12/build-support/jenkins/build-and-test.sh@355 PS12, Line 355: grep -q IIRC, some grep flavors wouldn't recognize regex patterns unless invoked as 'egrep' or 'grep -E'. I haven't checked whether that's the case for any of the supported OSes, but I'd rather use 'grep -Eq' instead of 'grep -q' here. -- To view, visit http://gerrit.cloudera.org:8080/24040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1d6d65fbd58a8c96d1dca958fc66207893bb99e Gerrit-Change-Number: 24040 Gerrit-PatchSet: 12 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2026 18:38:10 +0000 Gerrit-HasComments: Yes
