Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24085 )
Change subject: KUDU-3729 Prefer follower moves in auto-rebalancing ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/master/auto_rebalancer-test.cc@269 PS3, Line 269: > BuildClusterInfoForTest always passes an empty MovesInProgress. The new ts_ Done http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/master/auto_rebalancer-test.cc@1181 PS3, Line 1181: // production via BuildClusterRawInfoForTest + BuildClusterInfoForTest on a live > ts_with_followers_by_table_and_tag is populated in BuildClusterInfo but the Done http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/master/auto_rebalancer-test.cc@1204 PS3, Line 1204: K(BuildClusterInfoForTest(a > The test's name and its CheckNoLeaderMovesScheduled() call are mismatched. Done http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/master/auto_rebalancer.cc@151 PS3, Line 151: auto_rebalancing_prefer_follower_re > The flag=false branch has zero integration coverage. The counterpart to the Done http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/master/auto_rebalancer.cc@158 PS3, Line 158: TAG_FLAG(auto_rebalancing_prefer_follower_replica_moves, advanced); > nit: add a new line here. Done http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/rebalance/rebalance_algo-test.cc File src/kudu/rebalance/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/rebalance/rebalance_algo-test.cc@342 PS3, Line 342: TEST(RebalanceAlgoUnitTest, PreferFollowerMovesByTableAndTag) { > The existing test only covers the non_leader_move branch (source has a foll Done http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/rebalance/rebalance_algo.cc File src/kudu/rebalance/rebalance_algo.cc: http://gerrit.cloudera.org:8080/#/c/24085/3/src/kudu/rebalance/rebalance_algo.cc@375 PS3, Line 375: // Safe to stop scanning equal_range(max_table_skew): every table here > Can you please add a comment about why the early break on non_leader_move i Done -- To view, visit http://gerrit.cloudera.org:8080/24085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b56ae5ef8db5fe15ab25df1d1cebe84fd3b8f2c Gerrit-Change-Number: 24085 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 30 Mar 2026 13:59:11 +0000 Gerrit-HasComments: Yes
