Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24134 )
Change subject: [fs] fix partial blocks deletion case in rocksdb ...................................................................... [fs] fix partial blocks deletion case in rocksdb This fixes a bug in rocksdb block deletion logic where only a partial number of total blocks are successfully deleted, but the function returns total number of blocks as 'deleted' inside the out parameter i.e., 'deleted_block_ids'. However, the same case is handled in native container by resizing the out parameter to correct number of blocks that were deleted successfully, at the end of function scope. The fix is to apply the same scoped cleanup logic for rocksdb method as well by resizing the 'deleted_block_ids' out parameter with total number of committed blocks. A unit test is added to verify the same. Change-Id: Ifb553fbf9a88f0cdb392f926289bbdf5f18b5d29 Reviewed-on: http://gerrit.cloudera.org:8080/24134 Reviewed-by: Alexey Serbin <[email protected]> Reviewed-by: Marton Greber <[email protected]> Tested-by: Marton Greber <[email protected]> --- M src/kudu/fs/dir_manager.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h 4 files changed, 120 insertions(+), 0 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Marton Greber: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifb553fbf9a88f0cdb392f926289bbdf5f18b5d29 Gerrit-Change-Number: 24134 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
