Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24269 )
Change subject: KUDU-3690: Add filtering to /metrics_prometheus ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24269/3/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/24269/3/src/kudu/master/master-test.cc@4190 PS3, Line 4190: ASSERT_STR_NOT_CONTAINS(buf.ToString(), " 0\n"); : ASSERT_STR_NOT_CONTAINS(buf.ToString(), " 1\n"); > Could you explain a bit more what you are doing here? ah yea, this was a heuristic to check for no prometheus value lines. I intended to add a proper checker function, that i forgot to add. fixed this in the new patchset. thanks! http://gerrit.cloudera.org:8080/#/c/24269/3/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/24269/3/src/kudu/server/default_path_handlers.cc@499 PS3, Line 499: resp->status_code = HttpStatusCode::BadRequest; : WARN_NOT_OK(Status::InvalidArgument(""), "The parameter of 'attributes' is wrong"); : return false; > Shouldn't we write the error message into resp->output instead of using WAR ah yea, makes sense, done. thanks! -- To view, visit http://gerrit.cloudera.org:8080/24269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c0b23ae5c184bf9e33e453736cef5e7ce8ee2e1 Gerrit-Change-Number: 24269 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 06 May 2026 15:55:23 +0000 Gerrit-HasComments: Yes
