Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24269 )
Change subject: KUDU-3690: Add filtering to /metrics_prometheus ...................................................................... Patch Set 5: Code-Review+1 (2 comments) There is a question about assertion for rpcs_queue_overflow in a couple of tests. Probably, that's just a typo. Otherwise, LGTM. http://gerrit.cloudera.org:8080/#/c/24269/5/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/24269/5/src/kudu/master/master-test.cc@4371 PS5, Line 4371: ASSERT_STR_MATCHES(str, "threads_running "); // server entity, present The assertion for 'rpcs_queue_overflow' is omitted (which looks a bit surprising). Why? http://gerrit.cloudera.org:8080/#/c/24269/5/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/24269/5/src/kudu/tserver/tablet_server-test.cc@4748 PS5, Line 4748: ASSERT_STR_MATCHES(str, "threads_running "); // server entity, present What's with the "rpcs_queue_overflow" assertion? -- To view, visit http://gerrit.cloudera.org:8080/24269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c0b23ae5c184bf9e33e453736cef5e7ce8ee2e1 Gerrit-Change-Number: 24269 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2026 14:19:10 +0000 Gerrit-HasComments: Yes
