Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24287 )
Change subject: KUDU-3762 - Fix catchup deadlock on LMP mismatch ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/24287/7/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/24287/7/src/kudu/master/catalog_manager.h@1544 PS7, Line 1544: > nit: remove the extra string? Done http://gerrit.cloudera.org:8080/#/c/24287/7/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/24287/7/src/kudu/master/catalog_manager.cc@800 PS7, Line 800: { > It might be a bit cleaner if moving this condition inside the loop: The PS8 doesn't need this anymore http://gerrit.cloudera.org:8080/#/c/24287/7/src/kudu/master/catalog_manager.cc@1011 PS7, Line 1011: // Ensure we are setting the flag from false to true before shutting down > I think it's prudent to check for catalog_status_ here before setting is_jo Done http://gerrit.cloudera.org:8080/#/c/24287/7/src/kudu/master/catalog_manager.cc@7316 PS7, Line 7316: initial_term_(-1) { > nit: does it make sense to wrap this into PREDICT_FALSE? The ScopedLeaderS The PS8 doesn't need this and the below changes anymore http://gerrit.cloudera.org:8080/#/c/24287/7/src/kudu/master/catalog_manager.cc@7359 PS7, Line 7359: ::has_term_changed() const { Added the needed check in CatalogManager::SetJoiningCluster(). Thanks for the pointer > Is it really necessary to add this hack here? Wouldn't it be safer to add a > shortcut with 'if (is_joining_existing_cluster_)' clause in a few call sites > where CheckIsInitializedOrRespond() now responds with an error if not adding > this? Yes, done. That's a cleaner approach thanks -- To view, visit http://gerrit.cloudera.org:8080/24287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00f4f840c21cc037a2aa6c023af168352fef0761 Gerrit-Change-Number: 24287 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2026 21:52:52 +0000 Gerrit-HasComments: Yes
