Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24287 )
Change subject: KUDU-3762 - Fix catchup deadlock on LMP mismatch ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/24287/9/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/24287/9/src/kudu/master/catalog_manager.h@659 PS9, Line 659: ; > nit: could this member function be 'const'? Done http://gerrit.cloudera.org:8080/#/c/24287/9/src/kudu/master/catalog_manager.h@659 PS9, Line 659: GetJoiningCluster > style/naming nit: IsJoiningCluster() since it's a boolean flag Done http://gerrit.cloudera.org:8080/#/c/24287/9/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/24287/9/src/kudu/master/master_runner.cc@431 PS9, Line 431: // Shutdown the Catalog Manager to avoid propagating incorrect state of the system catalog : // table as the table will be replaced via AddMaster() anyway. See KUDU-3762. : LOG(INFO) << "Shutting down Catalog Manager Raft consensus"; > nit: does it make sense to move/encapsulate these three lines into SetJoini Done http://gerrit.cloudera.org:8080/#/c/24287/9/src/kudu/mini-cluster/external_mini_cluster-test.cc File src/kudu/mini-cluster/external_mini_cluster-test.cc: http://gerrit.cloudera.org:8080/#/c/24287/9/src/kudu/mini-cluster/external_mini_cluster-test.cc@480 PS9, Line 480: > nit: fix indentation? Done http://gerrit.cloudera.org:8080/#/c/24287/9/src/kudu/mini-cluster/external_mini_cluster-test.cc@487 PS9, Line 487: , > nit: add a space after the comma Done -- To view, visit http://gerrit.cloudera.org:8080/24287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00f4f840c21cc037a2aa6c023af168352fef0761 Gerrit-Change-Number: 24287 Gerrit-PatchSet: 9 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Sun, 17 May 2026 03:07:07 +0000 Gerrit-HasComments: Yes
