Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24328 )
Change subject: KUDU-3429 Make rows per block flag based (1/n) ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24328/1/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/24328/1/src/kudu/tablet/compaction.cc@94 PS1, Line 94: rowset_compaction_rows_per_block Is there lower/upper limits that make sense for this flag? E.g., would it work with 0 or 1? Since this update makes it configurable, does it make sense to catch misconfigurations in a flag validator? http://gerrit.cloudera.org:8080/#/c/24328/1/src/kudu/tablet/compaction.cc@97 PS1, Line 97: increasing peak RSS at the cost of higher memory " : "usage per operation. Higher memory usage is the cost, but what is the _benefit_ of a higher setting for this flag? E.g., 100 vs 200? -- To view, visit http://gerrit.cloudera.org:8080/24328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65f1e0d91e718b097bcc6e3979f246a13a618edf Gerrit-Change-Number: 24328 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 May 2026 18:35:49 +0000 Gerrit-HasComments: Yes
