Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24328 )
Change subject: KUDU-3429 Make rows per block flag based (1/n) ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24328/2/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/24328/2/src/kudu/tablet/compaction.cc@277 PS2, Line 277: block_(&base_iter_->schema(), FLAGS_rowset_compaction_rows_per_block, &mem_), : redo_mutation_block_(FLAGS_rowset_compaction_rows_per_block, static_cast<Mutation*>(nullptr)), : undo_mutation_block_(FLAGS_rowset_compaction_rows_per_block, static_cast<Mutation*>(nullptr)), > nit: this runtime flag is read three times here to size block_ and the muta While that is unlikely scenario, given the rarity of flag change actions and microsecond window between the statements, you still have a valid point from correctness and a potential race standpoint. Thank you for pointing this out. -- To view, visit http://gerrit.cloudera.org:8080/24328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65f1e0d91e718b097bcc6e3979f246a13a618edf Gerrit-Change-Number: 24328 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 13:19:29 +0000 Gerrit-HasComments: Yes
