Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24387 )
Change subject: KUDU-3779: support in-memory metadata replay for encrypted clusters ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24387/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/24387/1/src/kudu/fs/log_block_manager.cc@1487 PS1, Line 1487: s.size() > data_.size() || : offset - encryption_header_size_ > : data_.size() - s.size()) > IIUC, we could drop the 's.size() > data_.size()' condition since the secon s/hits/hints/ -- To view, visit http://gerrit.cloudera.org:8080/24387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37af5bc37613dd4081e1ad708f084e1c88fb3e75 Gerrit-Change-Number: 24387 Gerrit-PatchSet: 1 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 07:48:10 +0000 Gerrit-HasComments: Yes
