Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24387 )
Change subject: KUDU-3779: support in-memory metadata replay for encrypted clusters ...................................................................... Patch Set 1: Code-Review+1 (2 comments) LGTM! Just a couple of nits. http://gerrit.cloudera.org:8080/#/c/24387/1/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: http://gerrit.cloudera.org:8080/#/c/24387/1/src/kudu/fs/log_block_manager.h@227 PS1, Line 227: FRIEND_TEST(LogBlockManagerNativeMetaTest, nit: this should be above line:226 for order purpose. http://gerrit.cloudera.org:8080/#/c/24387/1/src/kudu/util/env.h File src/kudu/util/env.h: http://gerrit.cloudera.org:8080/#/c/24387/1/src/kudu/util/env.h@519 PS1, Line 519: return Read(raw_offset, result); nit: not important - see if you can add assert to ensure default implementation is for unencrypted data only. -- To view, visit http://gerrit.cloudera.org:8080/24387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37af5bc37613dd4081e1ad708f084e1c88fb3e75 Gerrit-Change-Number: 24387 Gerrit-PatchSet: 1 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 09:28:40 +0000 Gerrit-HasComments: Yes
