Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24435 )
Change subject: WIP KUDU-3780: introduce KUDU_CLIENT_ONLY build option ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/24435/1/src/kudu/cfile/CMakeLists.txt File src/kudu/cfile/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/1/src/kudu/cfile/CMakeLists.txt@33 PS1, Line 33: return() > I'm not sure all these early returns are needed as long as you use My goal was to make CLIENT_ONLY working regardless of the make/ninja target or other cmake flags. If it's acceptable to limit this only to 'kudu_client' and 'kudu_client_exported' targets, those early returns aren't needed, right. http://gerrit.cloudera.org:8080/#/c/24435/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/1/src/kudu/util/CMakeLists.txt@361 PS1, Line 361: set(UTIL_LIBS ${UTIL_LIBS} yaml) > Could be Yes, it could. I'm using the same pattern as for the rest of the UTIL_LIBS components -- see below. http://gerrit.cloudera.org:8080/#/c/24435/1/thirdparty/build-if-necessary.sh File thirdparty/build-if-necessary.sh: http://gerrit.cloudera.org:8080/#/c/24435/1/thirdparty/build-if-necessary.sh@36 PS1, Line 36: "client") > How does this get selected? This is selected by specifying command-line argument 'client' to the script. http://gerrit.cloudera.org:8080/#/c/24435/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/24435/1/thirdparty/build-thirdparty.sh@71 PS1, Line 71: "client") F_CLIENT=1 ;; > How does this get selected? This can be selected using passing command-line arguments to the $KUDU_ROOT/thirdparty/build-if-necessary.sh script, similar to 'tsan', 'common', etc. Would you prefer to be able to control this by other means? -- To view, visit http://gerrit.cloudera.org:8080/24435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b021e03808a3ca8da6cfff617bc913772f271 Gerrit-Change-Number: 24435 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 10 Jun 2026 23:05:14 +0000 Gerrit-HasComments: Yes
