Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24435 )
Change subject: WIP KUDU-3780: introduce KUDU_CLIENT_ONLY build option ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24435/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/1/CMakeLists.txt@1512 PS1, Line 1512: set(GENERATED_HEADERS_DEPS fb-gen hms_thrift) IIUC this overwrites GENERATED_HEADERS_DEPS rather than appending: set(GENERATED_HEADERS_DEPS fb-gen hms_thrift) loses the pb-gen, krpc-gen, gen_version_info set on line 1510. Shouldn't this be: set(GENERATED_HEADERS_DEPS ${GENERATED_HEADERS_DEPS} fb-gen hms_thrift)? -- To view, visit http://gerrit.cloudera.org:8080/24435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b021e03808a3ca8da6cfff617bc913772f271 Gerrit-Change-Number: 24435 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2026 12:51:49 +0000 Gerrit-HasComments: Yes
