Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24439 )
Change subject: KUDU-3782 avoid unsigned underflow in MaterializingIterator::Init ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24439/1/src/kudu/common/generic_iterators-test.cc File src/kudu/common/generic_iterators-test.cc: http://gerrit.cloudera.org:8080/#/c/24439/1/src/kudu/common/generic_iterators-test.cc@597 PS1, Line 597: ASSERT_FALSE(dst.selection_vector()->IsRowSelected(0)); nit: Maybe test for 19 too? http://gerrit.cloudera.org:8080/#/c/24439/1/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/24439/1/src/kudu/common/generic_iterators.cc@1177 PS1, Line 1177: num_columns() This already returns size_t and the casting below can be avoided? http://gerrit.cloudera.org:8080/#/c/24439/1/src/kudu/common/generic_iterators.cc@1193 PS1, Line 1193: non_predicate_column_indexes_.reserve Could there be a case where the number of columns in the projection is less than the number of columns in the predicate? For example something like: Table Schema: tenant_id (Primary Key) user_id (Primary Key) email (Regular Column) Query: SELECT email FROM users WHERE tenant_id = 'tenant42' AND user_id = 4242; What happens then? -- To view, visit http://gerrit.cloudera.org:8080/24439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I646ab64c2139b37c7e29152695805bf28ef1dd20 Gerrit-Change-Number: 24439 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 11 Jun 2026 23:40:53 +0000 Gerrit-HasComments: Yes
