Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24439 )
Change subject: KUDU-3782 avoid unsigned underflow in MaterializingIterator::Init ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24439/1/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/24439/1/src/kudu/common/generic_iterators.cc@1222 PS1, Line 1222: spec->RemovePredicates(); > RemovePredicates() clears all predicates from the spec, including the ones actually there is a TODO mentioning this scenario in tablet-pushdown-test.cc@L215, where a related test is disabled, I would suggest reviewing that to check if it would validate this scenario, also it probably would be a good idea to either remove only predicates that are actually accepted/evaluated by this iterator, or mark/remove the lifted PK-bound predicates at the place that creates them (CFileSet::Iterator::OptimizePKPredicates()) so arbitrary missing predicates cannot be dropped -- To view, visit http://gerrit.cloudera.org:8080/24439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I646ab64c2139b37c7e29152695805bf28ef1dd20 Gerrit-Change-Number: 24439 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2026 08:15:09 +0000 Gerrit-HasComments: Yes
