Marton Greber has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20814 )

Change subject: Add blog post about Prometheus/Grafana
......................................................................


Patch Set 1:

(8 comments)

After a while, with Prometheus features done I've sat down to revise this blog 
post.
If you have time please take a look.
Thank you!

http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:

http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@18
PS1, Line 18: JMX format
> I'm not sure what 'JMX format' means, but I might be missing something.  Co
Removed this part.


http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@24
PS1, Line 24:
> Do you think it's worth mentioning that currently Kudu exports only server-
Not sure if its worth calling out with all the improvements. It comes in 
'handy' that since 2023 a bunch of improvements went in for Prometheus, making 
it more feature complete. Hence the blog post can carry this notification 
signal.
Anyway let me know if you think its worthwhile to call out what we have in the 
current state in terms of Prometheus features.


http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@33
PS1, Line 33: ## Prometheus Configuration for Kudu
> As a side note, it would be much easier to integrate with Prometheus if Kud
Done


http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@44
PS1, Line 44:         # Set the interval at which Prometheus will scrape 
metrics for this job (5 seconds in this case)
> nit: break the line
Done


http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@55
PS1, Line 55:         - targets: ['localhost:8765', 'localhost:8767', 
'localhost:8769']
> how about using master1.example.com:8765 etc or some such instead of varyin
Done


http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@63
PS1, Line 63:         - targets: ['localhost:9871', 'localhost:9873', 
'localhost:9875']
> same here
Done


http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@93
PS1, Line 93:     <div align="center">
> do we need the div etc here? can we get away with markdown tags only?
Done


http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@172
PS1, Line 172: can create a script which parses the TServer addresses
> Consider mentioning KUDU-3538: ideally, Kudu masters could implement HTTP S
Removed this old approach, and replaced this section with SD details.



--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Fri, 03 Jul 2026 16:59:31 +0000
Gerrit-HasComments: Yes

Reply via email to