Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md File _posts/2026-07-03-kudu-prometheus-grafana.md: http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@8 PS2, Line 8: ([KUDU-3691](https://issues.apache.org/jira/browse/KUDU-3691)) nit: the outer parentheses around the link read like a typo. I think without the outside wrapping ( ) reads cleaner. http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@42 PS2, Line 42: ```yaml : global: : scrape_interval: 15s : evaluation_interval: 15s : : scrape_configs: : - job_name: 'kudu' : metrics_path: '/metrics_prometheus' : static_configs: : - targets: ['master-1:8051', 'master-2:8051', 'master-3:8051'] : labels: : group: 'masters' : - targets: ['tserver-1:8050', 'tserver-2:8050', 'tserver-3:8050'] : labels: : group: 'tservers' : ``` I think this YAML isn't valid: scrape_interval/evaluation_interval are at the same indent as global. Since readers will copy-paste this, could you verify this is correct? http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@80 PS2, Line 80: nit: trailing whitespace. http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@107 PS2, Line 107: ```yaml : global: : scrape_interval: 15s : evaluation_interval: 15s : : scrape_configs: : - job_name: 'kudu' : metrics_path: '/metrics_prometheus' : http_sd_configs: : - url: 'http://master-1:8051/prometheus-sd' : - url: 'http://master-2:8051/prometheus-sd' : - url: 'http://master-3:8051/prometheus-sd' : ``` same as the other yaml. http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@154 PS2, Line 154: [Prometheus documentation](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#http_sd_config). nit: missing trailing newline at the end of the file. -- To view, visit http://gerrit.cloudera.org:8080/20814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f Gerrit-Change-Number: 20814 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 06 Jul 2026 08:09:18 +0000 Gerrit-HasComments: Yes
