Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24630 )
Change subject: [tools/master] make move of a leader replica recoverable ...................................................................... Patch Set 1: (2 comments) Thank you for working on this! http://gerrit.cloudera.org:8080/#/c/24630/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/24630/1/src/kudu/master/catalog_manager.cc@5492 PS1, Line 5492: const ConsensusStatePB cstate_; nit: it looks like only leader_uuid_ is read after construction, so the full cstate_ copy seems unused. Could drop it, though I see the other tasks keep cstate_ around too, so feel free to leave it for consistency. http://gerrit.cloudera.org:8080/#/c/24630/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/24630/1/src/kudu/tools/kudu-admin-test.cc@499 PS1, Line 499: TEST_F(AdminCliTest, TestMoveReplicaIdempotent) { Would it be feasible to add a case that leaves a leader marked replace with its replacement promoted, then asserts the master steps it down and evicts it with no client involved? I think that'd exercise AsyncLeaderStepDownForReplacementTask directly. -- To view, visit http://gerrit.cloudera.org:8080/24630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b28ca4e41355bd82c76d50e137f06197b402bc Gerrit-Change-Number: 24630 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 27 Jul 2026 11:31:38 +0000 Gerrit-HasComments: Yes
