Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24630 )
Change subject: [tools/master] make move of a leader replica recoverable ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24630/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/24630/1/src/kudu/master/catalog_manager.cc@5492 PS1, Line 5492: const string leader_uuid_; > nit: it looks like only leader_uuid_ is read after construction, so the ful Done http://gerrit.cloudera.org:8080/#/c/24630/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/24630/1/src/kudu/tools/kudu-admin-test.cc@499 PS1, Line 499: TEST_F(AdminCliTest, TestMoveReplicaIdempotent) { > Would it be feasible to add a case that leaves a leader marked replace with Good idea, thanks! Done in PS2. -- To view, visit http://gerrit.cloudera.org:8080/24630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b28ca4e41355bd82c76d50e137f06197b402bc Gerrit-Change-Number: 24630 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 12:44:44 +0000 Gerrit-HasComments: Yes
