Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24293 )
Change subject: [java] Add JDK25 support ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/24293/5/java/kudu-backup/build.gradle File java/kudu-backup/build.gradle: http://gerrit.cloudera.org:8080/#/c/24293/5/java/kudu-backup/build.gradle@30 PS5, Line 30: force "org.apache.hadoop:hadoop-client-api:$versions.hadoop" : force "org.apache.hadoop:hadoop-client-runtime:$versions.hadoop" Would these work here too? force libs.hadoopClientApi force libs.hadoopClientRuntime http://gerrit.cloudera.org:8080/#/c/24293/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java: http://gerrit.cloudera.org:8080/#/c/24293/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java@91 PS5, Line 91: Class<?> nameServiceInterface = null; : for (Class<?> innerClass : InetAddress.class.getDeclaredClasses()) { : if ("NameService".equals(innerClass.getSimpleName())) { : nameServiceInterface = innerClass; : break; : } : } : if (nameServiceInterface == null) { : throw new ClassNotFoundException("java.net.InetAddress$NameService"); : } Would Class.forName(...) work here, or is there another reason I don't know for this rewrite? -- To view, visit http://gerrit.cloudera.org:8080/24293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d3835c9289ac9817c39a86b7be22a28818c5bb0 Gerrit-Change-Number: 24293 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2026 13:58:14 +0000 Gerrit-HasComments: Yes
