Zoltan Chovan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24293 )

Change subject: [java] Add JDK25 support
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24293/5/java/kudu-backup/build.gradle
File java/kudu-backup/build.gradle:

http://gerrit.cloudera.org:8080/#/c/24293/5/java/kudu-backup/build.gradle@30
PS5, Line 30:     force libs.hadoopClientApi
            :     force libs.hadoopClientRuntime
> Would these work here too?
Done


http://gerrit.cloudera.org:8080/#/c/24293/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java
File 
java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java:

http://gerrit.cloudera.org:8080/#/c/24293/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/FakeDNS.java@91
PS5, Line 91:         // removed (replaced by 
java.net.spi.InetAddressResolver), so Class.forName
            :         // throws ClassNotFoundException and we fall through to 
the resolver path below.
            :         final Class<?> nameServiceInterface = 
Class.forName("java.net.InetAddress$NameService");
            :         Field field = 
InetAddress.class.getDeclaredField("nameService");
            :         // Get the default NameService to fallback to.
            :         Method method = 
InetAddress.class.getDeclaredMethod("createNameService");
            :         method.setAccessible(true);
            :         Object fallbackNameService = method.invoke(null);
            :         // Create a proxy instance to set on the InetAddress 
field which will handle
            :         /
> Would Class.forName(...) work here, or is there another reason I don't know
no, it works, good catch



--
To view, visit http://gerrit.cloudera.org:8080/24293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d3835c9289ac9817c39a86b7be22a28818c5bb0
Gerrit-Change-Number: 24293
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Fri, 31 Jul 2026 14:12:56 +0000
Gerrit-HasComments: Yes

Reply via email to