Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24583 )

Change subject: KUDU-3788 an option to use pre-built thirdparty artifacts
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24583/13/thirdparty/build-thirdparty.sh
File thirdparty/build-thirdparty.sh:

http://gerrit.cloudera.org:8080/#/c/24583/13/thirdparty/build-thirdparty.sh@50
PS13, Line 50: KUDU_ROOT
nit: Is this still needed? I don't see it referenced anywhere.


http://gerrit.cloudera.org:8080/#/c/24583/13/thirdparty/vars.sh
File thirdparty/vars.sh:

http://gerrit.cloudera.org:8080/#/c/24583/13/thirdparty/vars.sh@52
PS13, Line 52: /opt/kudu/thirdparty
nit: Does it make sense to allow users to customize this? For example in a case 
where there are any file permissions blocking them to write into '/opt'?



--
To view, visit http://gerrit.cloudera.org:8080/24583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55b5b99fcbe60eec3f6ae19fa4f2e335f361d143
Gerrit-Change-Number: 24583
Gerrit-PatchSet: 13
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Fri, 31 Jul 2026 01:33:34 +0000
Gerrit-HasComments: Yes

Reply via email to