Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24583 )
Change subject: KUDU-3788 an option to use pre-built thirdparty artifacts ...................................................................... Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/24583/13/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/24583/13/thirdparty/build-thirdparty.sh@50 PS13, Line 50: > nit: Is this still needed? I don't see it referenced anywhere. Done http://gerrit.cloudera.org:8080/#/c/24583/14/thirdparty/prebuilt-utils.sh File thirdparty/prebuilt-utils.sh: http://gerrit.cloudera.org:8080/#/c/24583/14/thirdparty/prebuilt-utils.sh@172 PS14, Line 172: local plevel="${!plevel_var}" > nit: `$version` is validated just above (errors if empty), but `$plevel` Good point. Done. http://gerrit.cloudera.org:8080/#/c/24583/14/thirdparty/prebuilt-utils.sh@330 PS14, Line 330: return 0 > This `return 0` (combined with the callers at lines 369 and 410 invoking Good catch! Indeed, that's an overlook: it seems I'm giving too much credibility to certain AI tools :) Thanks a lot, this is now fixed. http://gerrit.cloudera.org:8080/#/c/24583/13/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/24583/13/thirdparty/vars.sh@52 PS13, Line 52: chain > nit: Does it make sense to allow users to customize this? For example in a No, it doesn't. This is a part of the pre-compiled PREFIX that must be the same for all the pre-built artifacts. If this changed, pre-compiled artifacts aren't going to work for -I/-L flags of the compiler/linker, and pkgconfig would return wrong location of the libraries and headers for 3rd-party components, etc. If regular (i.e. non-superuser) users do not have permissions for /opt/kudu/thirdparty, the script prompts them to grant the necessary permissions prior to commencing the build. -- To view, visit http://gerrit.cloudera.org:8080/24583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55b5b99fcbe60eec3f6ae19fa4f2e335f361d143 Gerrit-Change-Number: 24583 Gerrit-PatchSet: 14 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2026 21:16:45 +0000 Gerrit-HasComments: Yes
