Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24594 )
Change subject: auto_leader_rebalancer: best-effort leader step-down ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/24594/6/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/24594/6/src/kudu/master/auto_leader_rebalancer-test.cc@555 PS6, Line 555: ASSERT_OK(leader_rebalancer->RunLeaderRebalancer()); > q: this asserts moves were *scheduled* and the pass returned OK, which is t That's true that it doesn't confirm the injection actually fired. I tried adding a hit counter for it, but it felt like a bit much test-only machinery on top of the injection flag, especially since the ASSERT_OK is already doing the regression guard work, so I am leaving it as-is, but really appreciate you flagging it. http://gerrit.cloudera.org:8080/#/c/24594/6/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24594/6/src/kudu/master/auto_leader_rebalancer.cc@99 PS6, Line 99: DEFINE_bool(auto_leader_rebalancing_fail_moves_for_test, false, > nit: the flag description says it forces "every leader step-down RPC issued Done http://gerrit.cloudera.org:8080/#/c/24594/6/src/kudu/master/auto_leader_rebalancer.cc@102 PS6, Line 102: "is only used for testing."); > nit: consider also tagging this hidden (alongside unsafe), consistent with Done -- To view, visit http://gerrit.cloudera.org:8080/24594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb2c7a8bf750520d34d9aba62274dbe7433d80d Gerrit-Change-Number: 24594 Gerrit-PatchSet: 7 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2026 13:56:54 +0000 Gerrit-HasComments: Yes
