Hello Marton Greber, Zoltan Chovan, Zoltan Martonka, Kudu Jenkins, Abhishek
Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24594
to look at the new patch set (#5).
Change subject: auto_leader_rebalancer: best-effort leader step-down
......................................................................
auto_leader_rebalancer: best-effort leader step-down
When rebalancing leaders for a table, RunLeaderRebalanceForTable
resolved the current leader's address and sent a LeaderStepDown RPC
with RETURN_NOT_OK. A single transient failure (an RPC timeout, the
target briefly unavailable, or an election in flight) aborted the whole
rebalancing pass and skipped every remaining tablet and table in that
round.
A leader transfer is best effort. The next round recomputes the plan
and retries, so a single failed transfer should warn and move on to the
next tablet rather than fail the pass. RunLoop already only logs a
warning for the overall call, so this just stops one bad RPC from
starving the rest of the round.
Seen under heavy load, where one failed LeaderStepDown would otherwise
end a round early and leave the leaders unbalanced for longer.
Also add an IWYU mapping for <boost/move/detail/type_traits.hpp> to
<utility>. IWYU otherwise flip-flopped on that boost private detail
header for this file (adding it on one run, removing it the next), so
`ninja iwyu` couldn't stay green.
Change-Id: I0fb2c7a8bf750520d34d9aba62274dbe7433d80d
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
2 files changed, 70 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/24594/5
--
To view, visit http://gerrit.cloudera.org:8080/24594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0fb2c7a8bf750520d34d9aba62274dbe7433d80d
Gerrit-Change-Number: 24594
Gerrit-PatchSet: 5
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
