Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24293 )
Change subject: [java] Add JDK25 support ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/24293/8//COMMIT_MSG Commit Message: PS8: > With this patch, do we still expect JAVA8_OVERRIDE magic word working for o no changes in the build pipelines, with this path Kudu does compile and run with JDK25, I don't think we need to increase the minimum Java version to 25, it might be nice to introduce another jenkins job for JDK25 specific build and test, but that will be a separate task http://gerrit.cloudera.org:8080/#/c/24293/8/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/24293/8/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@975 PS8, Line 975: (SaslException) > nit: is this cast still required when 'cause instanceof SaslException' hold Good catch, the cast was needed because cause is typed as Throwable and a plain instanceof doesn't narrow it. Switched to pattern-matching instanceof SaslException se and use se directly, which removes the cast. http://gerrit.cloudera.org:8080/#/c/24293/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/24293/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@524 PS8, Line 524: CoreMatchers.containsString("authenticat"), : CoreMatchers.containsString("SASL"), : CoreMatchers.containsString("Kerberos"), : CoreMatchers.containsString("GSS"))); > nit: this makes the set of situations much wider than it was before. Is th right, that's fair, I tried to tighten the patterns so that we avoid the false positive matches, let me know if they still need work in your opinion -- To view, visit http://gerrit.cloudera.org:8080/24293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d3835c9289ac9817c39a86b7be22a28818c5bb0 Gerrit-Change-Number: 24293 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 14:50:15 +0000 Gerrit-HasComments: Yes
