Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24293 )
Change subject: [java] Add JDK25 support ...................................................................... Patch Set 8: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/24293/8//COMMIT_MSG Commit Message: PS8: With this patch, do we still expect JAVA8_OVERRIDE magic word working for old, but still officially maintained branches? If not, maybe explicitly mention this in the commit message. http://gerrit.cloudera.org:8080/#/c/24293/8/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/24293/8/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@975 PS8, Line 975: (SaslException) nit: is this cast still required when 'cause instanceof SaslException' holds true? http://gerrit.cloudera.org:8080/#/c/24293/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/24293/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@524 PS8, Line 524: CoreMatchers.containsString("authenticat"), : CoreMatchers.containsString("SASL"), : CoreMatchers.containsString("Kerberos"), : CoreMatchers.containsString("GSS"))); nit: this makes the set of situations much wider than it was before. Is this indeed the most common denominator across JDK/Kerberos implementations here? Maybe, there is a way to build a regex-based, more specific message? My concern is that we could start receiving something not so expected with matching against library names that might be present in the stack traces (or there isn't any stack traces in those messages at all?) -- To view, visit http://gerrit.cloudera.org:8080/24293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d3835c9289ac9817c39a86b7be22a28818c5bb0 Gerrit-Change-Number: 24293 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 03 Aug 2026 22:49:52 +0000 Gerrit-HasComments: Yes
