Hello Marton Greber, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24658
to look at the new patch set (#2).
Change subject: KUDU-3772 fix flakiness in MiniPrometheusTest.StartStopNoTargets
......................................................................
KUDU-3772 fix flakiness in MiniPrometheusTest.StartStopNoTargets
Before this fix, one of my RHEL9.6 x86_64 build/test machines would
regularly report a failure in the MiniPrometheusTest.StartStopNoTargets
scenario when running mini_prometheus-test. Reports looked like below:
src/kudu/util/mini_prometheus-test.cc:206: Failure
Failed
Bad status: Remote error: HTTP 503
This changelist address the issue.
I also tried a more generic approach, trying to rely on the documented
'/-/ready' URL [1] by running the readiness check right before returning
from the MiniPrometheus::Start() method. However, it seems getting
HTTP 200 for GET/HEAD requests at the '/-/ready' URL doesn't guarantee
that Scrape/Target Manager initialization is complete, so the readiness
check is useless in this context.
[1] https://prometheus.io/docs/prometheus/latest/management_api/
Change-Id: I05e9ca3e3c8782e9b073dd2329846d5eac661dcf
---
M src/kudu/util/mini_prometheus-test.cc
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/24658/2
--
To view, visit http://gerrit.cloudera.org:8080/24658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05e9ca3e3c8782e9b073dd2329846d5eac661dcf
Gerrit-Change-Number: 24658
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
