Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24658 )
Change subject: KUDU-3772 fix flakiness in MiniPrometheusTest.StartStopNoTargets ...................................................................... KUDU-3772 fix flakiness in MiniPrometheusTest.StartStopNoTargets Before this fix, one of my RHEL9.6 x86_64 build/test machines would regularly report a failure in the MiniPrometheusTest.StartStopNoTargets scenario when running mini_prometheus-test. Reports looked like below: src/kudu/util/mini_prometheus-test.cc:206: Failure Failed Bad status: Remote error: HTTP 503 This changelist address the issue. I also tried a more generic approach, trying to rely on the documented '/-/ready' URL [1] by running the readiness check right before returning from the MiniPrometheus::Start() method. However, it seems getting HTTP 200 for GET/HEAD requests at the '/-/ready' URL doesn't guarantee that Scrape/Target Manager initialization is complete, so the readiness check is useless in this context. [1] https://prometheus.io/docs/prometheus/latest/management_api/ Change-Id: I05e9ca3e3c8782e9b073dd2329846d5eac661dcf Reviewed-on: http://gerrit.cloudera.org:8080/24658 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Marton Greber <[email protected]> --- M src/kudu/util/mini_prometheus-test.cc 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Alexey Serbin: Verified Marton Greber: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I05e9ca3e3c8782e9b073dd2329846d5eac661dcf Gerrit-Change-Number: 24658 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
