Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24869 )
Change subject: KUDU-3788 an option to keep existing symlinks in /opt/kudu/thirdparty ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24869/1/thirdparty/prebuilt-utils.sh File thirdparty/prebuilt-utils.sh: http://gerrit.cloudera.org:8080/#/c/24869/1/thirdparty/prebuilt-utils.sh@267 PS1, Line 267: ln -nsf "$target_path" "$subdir" ln -nsf is not atomic. It does 'unlink' and 'symlink' under the hood, introducing a window where link doesn't exist. Consider using 'ln to temp path' and 'mv temp to final path'. -- To view, visit http://gerrit.cloudera.org:8080/24869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22f612f343a3f5ea3cca48836ebc76a167af59e7 Gerrit-Change-Number: 24869 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2026 06:22:48 +0000 Gerrit-HasComments: Yes
