Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24869 )
Change subject: KUDU-3788 an option to keep existing symlinks in /opt/kudu/thirdparty ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24869/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/24869/1/thirdparty/build-thirdparty.sh@55 PS1, Line 55: enviroments > typo: environments Done http://gerrit.cloudera.org:8080/#/c/24869/1/thirdparty/prebuilt-utils.sh File thirdparty/prebuilt-utils.sh: http://gerrit.cloudera.org:8080/#/c/24869/1/thirdparty/prebuilt-utils.sh@258 PS1, Line 258: if [ -L "$subdir" ] && stat -L "$subdir" > /dev/null 2>&1; then > nit: should we have also `[ -d "$subdir" ] ` in the if statement? Why? We are verifying that the link exists ('test -L "$subdir"') and points to an existing directory (stat -L "$subdir"). That's all what we need. http://gerrit.cloudera.org:8080/#/c/24869/1/thirdparty/prebuilt-utils.sh@265 PS1, Line 265: echo "Using existing symlink to $target_path" > nit: What do you think about adding more detail to this log statement like: Done -- To view, visit http://gerrit.cloudera.org:8080/24869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22f612f343a3f5ea3cca48836ebc76a167af59e7 Gerrit-Change-Number: 24869 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 21 Sep 2026 14:24:32 +0000 Gerrit-HasComments: Yes
