Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24945 )
Change subject: KUDU-3802 add cluster_leader_skew gauge ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24945/1/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/24945/1/src/kudu/master/ts_manager.cc@373 PS1, Line 373: return max_count - min_count; > LeaderSkew() correctly guards the empty case (min_count == INT_MAX ? return Done http://gerrit.cloudera.org:8080/#/c/24945/1/src/kudu/master/ts_manager.cc@379 PS1, Line 379: shared_lock l(lock_); > The dead-server exclusion branch in LeaderSkew isn't covered by either new Done -- To view, visit http://gerrit.cloudera.org:8080/24945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec82f841934f4e310509ee1b7156040b3bba5489 Gerrit-Change-Number: 24945 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2026 13:02:57 +0000 Gerrit-HasComments: Yes
