Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24945 )
Change subject: KUDU-3802 add cluster_leader_skew gauge ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24945/2/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/24945/2/src/kudu/master/master-test.cc@904 PS2, Line 904: FLAGS_tserver_unresponsive_timeout_ms = 500; : ASSERT_EVENTUALLY([&] { : NO_FATALS(heartbeat("ts-1", /*reg=*/false, 1)); : NO_FATALS(heartbeat("ts-3", /*reg=*/false, 3)); : ASSERT_EQ(2, skew()); : }); > Does this approach have flakiness potential? IIUC, the way how ASSERT_EVEN Ah, probably this isn't as bad as I thought initially: calling skew() immediately after tserver-to-master heartbeating should reset the inactivity interval. The only question is whether 500ms is enough to cover unexpected freezes/pauses in TSAN/ASAN builds between sending out ts-1's heartbeat and the time when skew() is called. -- To view, visit http://gerrit.cloudera.org:8080/24945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec82f841934f4e310509ee1b7156040b3bba5489 Gerrit-Change-Number: 24945 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2026 18:07:44 +0000 Gerrit-HasComments: Yes
