Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24946 )
Change subject: KUDU-3733 run auto-leader-rebalancer at startup ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24946/2/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24946/2/src/kudu/master/auto_leader_rebalancer.cc@997 PS2, Line 997: } while (!shutdown_.WaitFor(MonoDelta::FromSeconds( The flag has no validator, so --auto_leader_rebalancing_interval_seconds=0 is settable (it's runtime-tagged too). With 0, std::min(kPollIntervalSecs, 0) makes the tail WaitFor(FromSeconds(0)) return immediately, and pass_is_due (now - last_run_time >= FromSeconds(0)) is always true — so the loop hammers RunLeaderRebalancer() in a tight spin. This is pre-existing (the old loop also busy-looped on 0), so not introduced here, but this patch now reads the interval in two spots and the framing is "interval isn't how long to sleep." Worth deciding: clamp the poll to a floor (e.g. std::min(kPollIntervalSecs, std::max(1u, interval))) / add a GROUP_FLAG_VALIDATOR, or explicitly call it out of scope? A one-line comment noting 0 is degenerate would also be fine. -- To view, visit http://gerrit.cloudera.org:8080/24946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1b2a5622578c14a414fc79e4c527f9f7efbbce Gerrit-Change-Number: 24946 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2026 13:18:37 +0000 Gerrit-HasComments: Yes
