Gabriella Lotz has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24946 )

Change subject: KUDU-3733 run auto-leader-rebalancer at startup
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24946/2/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/24946/2/src/kudu/master/auto_leader_rebalancer.cc@997
PS2, Line 997:       if (ran) {
> The flag has no validator, so --auto_leader_rebalancing_interval_seconds=0
Thanks for pointing this out! I went with the clamp. The interval is read once 
per iteration now and floored at a second, so one value drives both the due 
check and the poll, which also folds away the double read you noticed.

I preferred that over a validator because the flag is runtime-tagged, so a 
validator would start rejecting set_flag calls and startup configs that are 
accepted today.



--
To view, visit http://gerrit.cloudera.org:8080/24946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1b2a5622578c14a414fc79e4c527f9f7efbbce
Gerrit-Change-Number: 24946
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Wed, 30 Sep 2026 14:22:38 +0000
Gerrit-HasComments: Yes

Reply via email to