Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24970 )

Change subject: KUDU-3809 enable table location caching by default
......................................................................


Patch Set 1:

> looks like some tests consistently fail across all the build types
 > with this change:
 > create-table-itest.0,
 > client-test.1,
 > table_locations-itest.0

+1

It could be related to some tests assuming that caching is disabled by default 
and based on that assertions are made. Those would require explicit disabling 
of caching.

It would be great to verify whether there is enough coverage of how catalog 
manager manages table location cache (when it is enabled) for different code 
paths (e.g. add_range_partition, drop_range_partition, concurrent scan and 
cache invalidation, etc).

On a side note, TableLocationsCacheBaseTest based tests have either 0 or 1 as 
'cache_capacity_mb' - should we add couple more tests with the default value 
i.e. 64MiB ?


--
To view, visit http://gerrit.cloudera.org:8080/24970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63eb9acf094e6f97ab3becf98325e4a0c9575c1e
Gerrit-Change-Number: 24970
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Tue, 29 Sep 2026 09:36:10 +0000
Gerrit-HasComments: No

Reply via email to