Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24966 )
Change subject: KUDU-2874 Updates decrease huge table batch size too ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Just some test suggestions, otherwise looks good to me. http://gerrit.cloudera.org:8080/#/c/24966/1/src/kudu/tserver/ordered_scan_large_cells-test.cc File src/kudu/tserver/ordered_scan_large_cells-test.cc: http://gerrit.cloudera.org:8080/#/c/24966/1/src/kudu/tserver/ordered_scan_large_cells-test.cc@580 PS1, Line 580: TEST_F(OrderedScanLargeCellsTest, TestAutoBatchSizeOverrideForUpdates) { TestAutoBatchSizeOverrideForUpdates covers the happy path well (update lowers the batch size, arithmetic bound checked). But the new branch's two guards are what's novel, and neither is exercised: - A refused update cell (> max_huge_cell_size_bytes) should not lower the batch size - mirror TestRefusedCellDoesNotLowerBatchSize, which today only exercises upserts. This locks in the changelist.is_null() path. - Optionally, an UPDATE_IGNORE on a non-existent row should not lower it either (the failed-flag path). What do you think? -- To view, visit http://gerrit.cloudera.org:8080/24966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icca95e3cec81c243c82a995b05d8e1deedbea553 Gerrit-Change-Number: 24966 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2026 08:52:40 +0000 Gerrit-HasComments: Yes
