Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24945 )
Change subject: KUDU-3802 add cluster_leader_skew gauge ...................................................................... Patch Set 3: Code-Review+2 (2 comments) LGTM. Maybe Marton has more feedback as of PS3. http://gerrit.cloudera.org:8080/#/c/24945/2/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/24945/2/src/kudu/master/master-test.cc@904 PS2, Line 904: // : // The timeout has to be long enough that a pause between the heartbeats : // forged below and the gauge read that follows them can't make a server that : // just heartbeated look dead -- TSAN and ASAN builds stall for a while -- and : // short enough that waiting 'ts-0' out fits in ASSERT_EVENTUALLY's budget. : // > Right, the skew() read does happen immediately after the heartbeats. I've r PS3 looks good to me in this regard, thank you for the update! http://gerrit.cloudera.org:8080/#/c/24945/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/24945/2/src/kudu/master/master_service.cc@466 PS2, Line 466: req->num_raft_leaders() > I think the check is already there, one call deeper: TSDescriptor::set_num_ Indeed -- it seems I checked the upstream source for the number of Raft leaders first, and missed updating this comment once seeing DCHECK() in TSDescriptor::set_num_raft_leaders(). This looks good to me as of PS2 and PS3 then, no need to update anything here. -- To view, visit http://gerrit.cloudera.org:8080/24945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec82f841934f4e310509ee1b7156040b3bba5489 Gerrit-Change-Number: 24945 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2026 06:00:01 +0000 Gerrit-HasComments: Yes
