Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )
Change subject: [net] preserve errno from failed recv() ...................................................................... Patch Set 1: (2 comments) Overall looks good to me. Just one suggestion to add end-to-end test and a nit. http://gerrit.cloudera.org:8080/#/c/25016/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/25016/1//COMMIT_MSG@9 PS1, Line 9: If the : peer lookup also fails nit: Maybe mention - After a connection reset, peer lookup fails... http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc@281 PS1, Line 281: TestRecvPreservesErrnoWhenPeerLookupFails Along with this, consider adding an end-to-end test without fault injection. -- To view, visit http://gerrit.cloudera.org:8080/25016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b Gerrit-Change-Number: 25016 Gerrit-PatchSet: 1 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 05 Oct 2026 13:24:56 +0000 Gerrit-HasComments: Yes
