Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )
Change subject: [net] preserve errno from failed recv() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/25016/1/src/kudu/util/net/socket-test.cc@281 PS1, Line 281: TestRecvPreservesErrnoWhenPeerLookupFails > I guess we do have a bunch of end-to-end tests that exercise Socket::Recv() Sure! I guess the idea is to run the test without overriding the GetPeerAddress() (getpeername()) from base class Socket, covering real syscall behavior. Something like: BindAndListen Connect client Accept and close on server-side client->Recv it should get ECONNRESET with apt error string. It is not a must have but it gives a test coverage on actual underlying syscall behavior. -- To view, visit http://gerrit.cloudera.org:8080/25016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b Gerrit-Change-Number: 25016 Gerrit-PatchSet: 1 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 05 Oct 2026 17:03:28 +0000 Gerrit-HasComments: Yes
