Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/25016 )
Change subject: [net] preserve errno from failed recv() ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/25016/2/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/25016/2/src/kudu/util/net/socket-test.cc@327 PS2, Line 327: const struct linger reset_linger = {1, 0}; : ASSERT_EQ(0, setsockopt(server.GetFd(), SOL_SOCKET, SO_LINGER, : &reset_linger, sizeof(reset_linger))); > nit: could use Socket::SetLinger(bool enable, int linger_timeout_sec = 0) h Used SetLinger(true) in PS3, with FRIEND_TEST for the private helper. -- To view, visit http://gerrit.cloudera.org:8080/25016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9196b35ee15d2111379a5a504745e83c831b640b Gerrit-Change-Number: 25016 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 06 Oct 2026 08:05:56 +0000 Gerrit-HasComments: Yes
