Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24978 )
Change subject: KUDU-3811 [tools] add 'kudu cluster check_location_maintenance' ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/24978/2/src/kudu/tools/location_maintenance.cc File src/kudu/tools/location_maintenance.cc: http://gerrit.cloudera.org:8080/#/c/24978/2/src/kudu/tools/location_maintenance.cc@54 PS2, Line 54: const int majority = rf / 2 + 1; During 3-4-3 reconfig an RF=3 tablet has 4 voters (real majority 3); 2-on-target/2-healthy-off reports SAFE while the live config would lose quorum. Conservative when under-replicated, optimistic here. Intentional? http://gerrit.cloudera.org:8080/#/c/24978/2/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/24978/2/src/kudu/tools/tool_action_cluster.cc@313 PS2, Line 313: locations.insert(ts.ts_location); "" from un-located tservers is inserted into locations, so a cluster with real locations /L0,/L1 + some un-located tservers passes invariant 1 with only two real failure domains. Should "" be excluded from the count? Add a test for a mixed located/un-located cluster. http://gerrit.cloudera.org:8080/#/c/24978/2/src/kudu/tools/tool_action_cluster.cc@337 PS2, Line 337: FLAGS_location, JoinStrings(vector<string>(locations.begin(), : locations.end()), ", "))); JoinStrings over locations renders "" as an empty slot ([, /L0, /L1]); use <unassigned> for consistency. -- To view, visit http://gerrit.cloudera.org:8080/24978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd4cbaa8dab835d4d27270c06b4b0028aab8285b Gerrit-Change-Number: 24978 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 16:41:38 +0000 Gerrit-HasComments: Yes
