Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24978 )
Change subject: KUDU-3811 [tools] add 'kudu cluster check_location_maintenance' ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Looks good apart from the possible missing location info that Marton already mentioned http://gerrit.cloudera.org:8080/#/c/24978/2/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/24978/2/src/kudu/tools/tool_action_cluster.cc@22 PS2, Line 22: #include <iostream> : #include <iomanip> Please run and fix "make iwyu" on ubuntu 18. http://gerrit.cloudera.org:8080/#/c/24978/2/src/kudu/tools/tool_action_cluster.cc@313 PS2, Line 313: locations.insert(ts.ts_location); > "" from un-located tservers is inserted into locations, so a cluster with r If we have any unlocated TServers, does this whole "safe to turn off region" check does any sense? They might or might not be in the turned down location. Would't the command straight up refusing to calculate if there are unlocated TServers make sense? -- To view, visit http://gerrit.cloudera.org:8080/24978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd4cbaa8dab835d4d27270c06b4b0028aab8285b Gerrit-Change-Number: 24978 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 07 Oct 2026 06:49:33 +0000 Gerrit-HasComments: Yes
